https://bugzilla.redhat.com/show_bug.cgi?id=2351539
--- Comment #24 from Attila Kovacs <[email protected]> --- Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-43-x86_64/09783314-redisx/redisx.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-43-x86_64/09783314-redisx/redisx-1.0.1-1.fc43.src.rpm Hi Terje! Thanks for the review. I have implemented all your suggestions. I do wonder about the %autosetup though in: >> %setup -q -n redisx-%{upstream_version} > Use autosetup and remove use of both -n option and %{upstream_version} > variable. Does %autosetup, without the -n option, handle the case when the upstream version is different from the package version, such as for release candidates, e.g. '1.1.0-rc3' (upstream) vs '1.1.0~rc3' (RPM)? Thanks, -- A. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2351539 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202351539%23c24 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
