https://bugzilla.redhat.com/show_bug.cgi?id=2390640
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | --- Comment #16 from Ben Beasley <[email protected]> --- Looking at the spec-file diff from the previous submission, I can confirm that all three suggestions from the previous review were correctly implemented. ==== --- ../../srpm-unpacked/meow.spec 2025-11-04 00:00:00.000000000 +0000 +++ srpm-unpacked/meow.spec 2025-11-10 00:00:00.000000000 +0000 @@ -13,7 +13,7 @@ # MIT OR Apache-2.0 License: %{shrink: MIT AND - (Apache-2.0 AND MIT) AND + (Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) } URL: https://github.com/pixelsergey/meow @@ -32,6 +32,7 @@ %prep %autosetup %cargo_prep + %generate_buildrequires %cargo_generate_buildrequires @@ -39,11 +40,12 @@ %cargo_build %{cargo_license} > LICENSE.dependencies %{cargo_license_summary} -help2man --no-info --output=meow.1 --name='%{summary}' target/rpm/meow-cli %install install -p -D target/rpm/meow-cli %{buildroot}%{_bindir}/meow -install -t %{buildroot}%{_mandir}/man1 -D -p -m 0644 meow.1 +install -d %{buildroot}%{_mandir}/man1 +help2man --no-info --output=%{buildroot}%{_mandir}/man1/meow.1 \ + --name='%{summary}' %{buildroot}%{_bindir}/meow %check %cargo_test ==== The man page still has "meow-cli" in it in several places, even though the SYNOPSIS section correctly has "meow". It turns out that this is because "meow --version" prints "meow-cli 2.1.5", and help2man is picking up the command name from there. Local testing suggests that you can fix this and get "MEOW(1)" and "meow" everywhere by overriding the version string, i.e., changing the help2man invocation to: help2man --no-info --name='%{summary}' --version-string='%{version}' \ --output=%{buildroot}%{_mandir}/man1/meow.1 \ %{buildroot}%{_bindir}/meow While I strongly suggest fixing this on import, the package is now APPROVED. ==== Some recommended post-import tasks: - set up package on release-monitoring.org - add @rust-sig with "commit" access as package co-maintainer This is not mandatory for "application" packages like this one, where the source package name is not of the form rust-*, but it makes it easier for Rust SIG members to help out with package maintenance. It’s your choice. - track package in koschei for all built branches ==== It seems like you’re looking for a sponsor into the packager group in Fedora (https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/, https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/). I would be willing to sponsor you based on our interactions in this review ticket, but you need to follow the other steps in https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ first. Particularly, please introduce yourself on the devel mailing list and sign the Fedora Project Contributor Agreement at https://accounts.fedoraproject.org/user/pixelsergey/settings/agreements/. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2390640 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202390640%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
