https://bugzilla.redhat.com/show_bug.cgi?id=2413958



--- Comment #1 from Antonio T. sagitter <[email protected]> ---
This is a pre-release of 5.0.0 and Version/Release/Source tags are not correct,
you are not using rpmautospec
(https://fedora-infra.github.io/rpmautospec-docs/)

code -->

%global gitcommit d243218119b1632987df26baea0d4bc6ccdee533
%global gitdate 20251013
%global shortcommit %(c=%{gitcommit}; echo ${c:0:7})

...

Version: 5.0.0
Release: %autorelease -p -s %{gitdate}git%{shortcommit}

...

Source0: %{url}/archive/%{gitcommit}/JKQtPlotter-%{gitcommit}.tar.gz
...

%changelog
%autochangelog

<--- code

BuildRequires against gcc, gcc-c++ are missing.

There is a license not listed:
$ licensecheck ./lib/jkqtmathtext/resources/firaMath/LICENSE
./lib/jkqtmathtext/resources/firaMath/LICENSE: SIL Open Font License 1.1

Looks like build flags are not used; add %set_build_flags before %cmake 


There are still many rpaths defined, try to use `-DCMAKE_SKIP_RPATH:BOOL=ON`
with %cmake


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2413958

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202413958%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to