https://bugzilla.redhat.com/show_bug.cgi?id=2399913
Michel Lind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |m) --- Comment #3 from Michel Lind <[email protected]> --- Are those header files (and cpp files in the same folders) needed? They should probably either be deleted or packaged as -devel. I suspect upstream build script bugs. The desktop file probably should be validated konqi-calling.png.license should probably be tagged %license systemd-rpm-macros BR-ed on but no systemd scriptlet used Issues: ======= - Header files in -devel subpackage, if present. Note: plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.language/languageutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.prepare/prepareutil.h plasma-setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timeutil.h plasma- setup : /usr/share/plasma/packages/org.kde.plasmasetup.time/timezonemodel.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file konqi-calling.png.license is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in plasma-setup See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399913 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399913%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
