https://bugzilla.redhat.com/show_bug.cgi?id=2415364
--- Comment #4 from Ben Beasley <[email protected]> --- Yes, it’s my understanding that it is not possible in general to mix vendored dependencies with separately-packaged ones, except in very limited cases like https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_replacing_git_dependencies. You shouldn’t be adding manual BuildRequires on rust-*-devel packages; all such dependencies should be handled with %cargo_generate_buildrequires, https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_dynamically_generated_buildrequires_for_crate_dependencies. You probably tried this because you were trying to find a way to mix vendored and system dependencies. > I've come down to this list of requirements, there is quite a lot that is > packaged in fedora, but the fact that we still have dependencies that need to > bundle, make this really hard to pull off during the rpm build. I’m curious why certain dependencies need to be bundled. Normally, when you need a crate that isn’t packaged, you’re expected to go package it. (You would be responsible for reviewing its contents if you shipped it in a vendor tarball anyway!) When a crate library is already in Fedora, but with an incompatible version, the answer may be to ask the maintainer to update it, patch the version bound in your Cargo.toml if possible, or in some cases create a compat package. > Also, during that analysis, it looks like there are some Windows dependencies > getting in the mix, which is not useful here, so I will work with upstream to > only require them if the target of building is Windows. That’s a good plan. You can also patch these out downstream for now. You can and should also patch out benchmark-only dev-dependencies like criterion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2415364 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202415364%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
