https://bugzilla.redhat.com/show_bug.cgi?id=2416532
--- Comment #5 from Felix Wang <[email protected]> --- > a) Koji build: > https://koji.fedoraproject.org/koji/taskinfo?taskID=139160324 Thanks. > b) One file is under BSD-2-Clause > https://gitlab.com/ubports/development/core/cmake-extras/-/blob/main/src/Vala/ValaConfig.cmake?ref_type=heads#L10-33 Added BSD-2-Clause to License field in the file. > c) The package seems like it should be a noarch package Done. > d) Can any of the examples be run to check things work? If not, is gcc-c++ > needed? I tried to run the examples in %check section. gcc-c++ should be required. If not, it will show the following error: ``` CMake Error at /usr/share/cmake/Modules/CMakeDetermineCCompiler.cmake:49 (message): Could not find compiler set in environment variable CC: gcc. Call Stack (most recent call first): CMakeLists.txt:2 (project) -- Configuring incomplete, errors occurred! CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage error: Bad exit status from /var/tmp/rpm-tmp.4q5J87 (%build) Bad exit status from /var/tmp/rpm-tmp.4q5J87 (%build) ``` > e) Can you raise an issue upstream to update FSF addresses? Done. I have reported to upstream in https://gitlab.com/ubports/development/core/cmake-extras/-/issues/11, which should be the only thing with this error. https://docs.fedoraproject.org/en-US/package-maintainers/CommonRpmlintIssues/#incorrect_fsf_address > f) The project seems independently developed of CMake, but puts files in > /usr/share/cmake rather than in /usr/share/cmake/cmake-extras > is there a possibility of conflicts? I think it will not cause conflicts. The cmake-extras package in OpenSUSE, Apline, Arch also puts files in /usr/share/cmake. [1,2,3] [1] https://build.opensuse.org/projects/openSUSE:Factory/packages/cmake-extras/files/cmake-extras.spec?expand=1 [2] https://pkgs.alpinelinux.org/contents?name=cmake-extras&repo=community&branch=edge&arch=x86_64 [3] https://archlinux.org/packages/extra/any/cmake-extras/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2416532 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416532%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
