https://bugzilla.redhat.com/show_bug.cgi?id=2383783
--- Comment #8 from Luya Tshimbalanga <[email protected]> --- Almost there. python3.patch is unnecessary by replacing it by "sed -i "s|env python|env python3|g" beutil.py convert2dashes.py considering one line. Skipping other lines from review. [x]: License field in the package spec file matches the actual license. Note Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "Creative Commons Attribution-ShareAlike 3.0", "*No copyright* GNU General Public License, Version 2". 124 files have unknown license. Detailed output of licensecheck in /home/luya/Documents/fedora- review/2383783-inkscape-silhouette/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Add "Creative Commons Attribution-ShareAlike 3.0" and mention "sendto_silhouette.py" file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2383783 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202383783%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
