https://bugzilla.redhat.com/show_bug.cgi?id=2403330



--- Comment #3 from Artur Frenszek-Iwicki <[email protected]> ---
> License:        FSFAP AND GPL-3.0-or-later AND MIT AND CC0-1.0 AND 
> LGPL-3.0-only AND Unlicense AND LGPL-2.0-or-later AND LGPL-2.1-only AND 
> BSD-3-Clause AND CC-BY-SA-4.0 AND GPL-2.0-or-later
Please add a comment describing the licensing breakdown.

> desktop-file-validate 
> %{buildroot}/%{_datadir}/applications/org.kde.kretro.desktop
> appstream-util validate-relax --nonet 
> %{buildroot}%{_metainfodir}/*.metainfo.xml
Arguably, this should be moved from %install to %check.

Also, rpmlint says:
> E: incorrect-fsf-address /usr/share/licenses/kretro/GPL-2.0-or-later.txt
> E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.0-or-later.txt
> E: incorrect-fsf-address /usr/share/licenses/kretro/LGPL-2.1-only.txt
Might be good to report this upstream.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2403330

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202403330%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to