https://bugzilla.redhat.com/show_bug.cgi?id=2414070
--- Comment #4 from Dominik 'Rathann' Mierzejewski <[email protected]> --- Thanks for the review! (In reply to Jerry James from comment #3) > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/lib/.build- > id/f7/52d2cb0f75547c1a661ccec026732acb6158bc > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files > > This file corresponds to /usr/bin/freenect-cvdemo, which is part of the > libfreenect-opencv package. This seems to be related to the %exclude > directives in %files. If I remove the %exclude directives and expand > "%{_bindir}/freenect-*" to this list: > > %{_bindir}/freenect-camtest > %{_bindir}/freenect-chunkview > %{_bindir}/freenect-cpp_pcview > %{_bindir}/freenect-cppview > %{_bindir}/freenect-glpclview > %{_bindir}/freenect-glview > %{_bindir}/freenect-hiview > %{_bindir}/freenect-micview > %{_bindir}/freenect-regtest > %{_bindir}/freenect-regview > %{_bindir}/freenect-tiltdemo > %{_bindir}/freenect-wavrecord > > then the warning goes away. That's also the approach recommended by > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Fixed. > - Regarding the license, there are also files under the MIT license: > fakenect/parson.c and fakenect/parson.h > > Those files are copied from https://github.com/kgabis/parson. They should > either be unbundled (preferably), or the appropriate "Provides: bundled" > should be added. It's an old version from 2017. Added bundled Provides: for now. > - The openni subpackage can be installed by itself and does not contain the > license files. Fixed. > - The %{?python_provide} invocation in python3-libfreenect does nothing. It > should be removed. Removed. > - The __provides_exclude at the top of the spec file is no longer needed. It > can be removed. Removed. > - Please replace "/lib/udev/rules.d" with "%{_udevrulesdir}" everywhere. Replaced. > - If this package is not needed on i686, please add "ExcludeArch: %{ix86}"; > see > https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval Added, > - Not a problem, just an observation: the -n %{name}-%{version} argument to > %setup in %prep is not needed, as that is the default; i.e., just "%setup > -q" > is enough. Dropped. > - Note the shlib-policy-excessive-dependency warning from rpmlint below. The > issue is that %{_libdir}/fakenect/libfakenect.so.0.7.5 depends only on libc > and libm, but /usr/bin/fakenect-record, in the same package, depends on > several other libraries. If somebody needs the package solely for the > library, they will have to deal with the additional dependencies dragged in > by the binary. Should the binary & library be in separate packages? It doesn't make sense to separate them in my opinion. > - Note the non-executable-script warning from rpmlint below. Should > fwfetcher.py be executable? If so, add the executable bit. If not, remove > the shebang. Added executable bit and fixed the shebang. > - Note the file-contains-date-and-time warning from rpmlint below. The build > can be made more reproducible by changing HTML_TIMESTAMP fron YES to NO in > doc/Doxyfile. Fixed. Spec URL: https://rathann.fedorapeople.org/review/libfreenect/libfreenect.spec SRPM URL: https://rathann.fedorapeople.org/review/libfreenect/libfreenect-0.7.5-2.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2414070 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202414070%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
