https://bugzilla.redhat.com/show_bug.cgi?id=2231216
Tadej Janež <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(errornointernet@e | |nvs.net) --- Comment #19 from Tadej Janež <[email protected]> --- My comments to the SPEC file: > BuildRequires: automake I don't think it is a good practice to recreate the project's scripts by running ./automake.sh below? I would rather just BuildRequire make. > %autosetup -p1 Since there are no patches, it should be enough to just call "%autosetup". > %build > ./automake.sh As said above, I would remove this line and just keep the "%configure" and "%make_build". Can you add a comment line here above to explain why this is being done? E.g.: # Renaming binaries and man page to avoid conflicts with the par2cmdline package. > mv %{buildroot}%{_bindir}/par2 %{buildroot}%{_bindir}/par2turbo > rm -f %{buildroot}%{_bindir}/par2create \ > %{buildroot}%{_bindir}/par2repair \ > %{buildroot}%{_bindir}/par2verify \ > %{buildroot}%{_bindir}/par2 Removing %{buildroot}%{_bindir}/par2 can be skipped since it has been renamed to par2turbo in the mv command above. > ln -s par2turbo %{buildroot}%{_bindir}/par2turbo-create > ln -s par2turbo %{buildroot}%{_bindir}/par2turbo-repair > ln -s par2turbo %{buildroot}%{_bindir}/par2turbo-verify > mv %{buildroot}%{_mandir}/man1/par2.1 %{buildroot}%{_mandir}/man1/par2turbo.1 In the next step, it would make sense to file an issue with the upstream and ask them to rename things there. > %check > %make_build check-TESTS I think "make check-TEST" should be sufficient. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2231216 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231216%23c19 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
