https://bugzilla.redhat.com/show_bug.cgi?id=2417094
--- Comment #3 from Qiyu Yan <[email protected]> --- Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/evtgen/fedora-rawhide-x86_64/09844087-evtgen/evtgen.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/evtgen/fedora-rawhide-x86_64/09844087-evtgen/evtgen-3.00.00b1-2.fc44.src.rpm Thank you so much for your review, I updated the spec file accordingly. For your remarks: - unowned dir: add %dir on /usr/share/EvtGen (only subdir /usr/share/EvtGen/cmake is owned now) Done, now the dir should belong to -data sub-package - the ? in sourceurl confuses various tooling, the correct checksum is: $ sha256sum EvtGen-03.00.00-beta1.tar.gz 59dbf2f4f91dbd59072e3e2ef53ce60cdbc6a5021f0df3001c43d6350716167d EvtGen-03.00.00-beta1.tar.gz Add comment about that in spec file? Upstream uses this kind of link so we can't do much about it. But yes, comment updated - there are various tests/validation available, can you try to add %check with some of that? It seems that enabling test don't give me any executables. And the validation seems to be for internal usage, some lack required input (like testCPVDecays), some are just for plotting and only genExampleRootFiles seems to run, but there is still no documentation of how to validate the ROOT file it generates. - can you comment on the undefined-non-weak-symbol in /usr/lib64/libEvtGenExternal.so.2.2.0 Where are those symbols? In Base? It is defined in libEvtGen.so.xxx, changed the cmake file to link libEvtGenExternal against libEvtGen which should solve those problem. ====== And changed the spec file that the changes to the source is done via a patch file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417094 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417094%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
