https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #16 from Steve Cossette <[email protected]> --- Created attachment 2116876 --> https://bugzilla.redhat.com/attachment.cgi?id=2116876&action=edit python-dsinternals build log Actually, it seems Michal is right here: https://docs.fedoraproject.org/en-US/epel/epel-packaging/#_python i.e.: `EPEL 8 Python packages MUST use the older guidelines.` Mainly because the new python scripts are not in EPEL8. Some suggestions:: This section: # python3-tox-current-env package is not available on EPEL8 # https://src.fedoraproject.org/rpms/python-tox-current-env %if 0%{?fedora} || ( 0%{?rhel} && 0%{?rhel} >= 9 ) BuildRequires: python%{python3_pkgversion}-tox-current-env %endif Can be removed. The `%pyproject_buildrequires -t` macro, specifically the -t part, gets the tox BRs automatically. So it is redundant. In the %check section: # EPEL8 missing tox dependency used for tests %if 0%{?fedora} || ( 0%{?rhel} && 0%{?rhel} >= 9 ) python3 -m unittest discover -v %tox %endif You don't need both %tox and the python tests, they both run the same tests. %tox is fine. No need for the python3 unittest module to be ran. There's other choices though, up to you. I would see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests for more information. But with that being said, I also tried to build this on epel8, and I get an error with dnf not finding setuptools (See attached log). Looking at the dnf logs, it seems to sometimes get python3.12-specific packages, and sometimes just python3 ones, maybe that's why? NOTE: To build, I used the same exact spec you provided in your last comment. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259466 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259466%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
