https://bugzilla.redhat.com/show_bug.cgi?id=2416680
Yaakov Selkowitz <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #6 from Yaakov Selkowitz <[email protected]> --- `BuildRequires: cmake(VulkanHeaders)` shouldn't be necessary -- there is no direct reference to anything vulkan in this package -- but I see there is a warning without it. It seems some other qt6-*-devel package needs to Requires it instead. It's okay to leave the BuildRequires for now, but with a comment explaining why it's necessary and a PR in the correct package to fix it. The `%find_lang` call should be in `%install`, not '%check`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2416680 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416680%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
