https://bugzilla.redhat.com/show_bug.cgi?id=2418666
--- Comment #2 from Carl George 🤠<[email protected]> --- Overall this looks pretty good, but I do recommend a few adjustments. The Python guidelines recommend using the -l flag with %pyproject_save_files to terminate the build if the license file is missing. This can be done with the pyproject BuildSystem by adding that flag like so: -BuildOption(install): openapi_pydantic +BuildOption(install): -l openapi_pydantic https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros The pyproject BuildSystem adds a basic %check section with %pyproject_check_import. Upstream has a test suite that should also be run. This can be done by appending to the %check section like so: +%check -a +%pytest https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/rawhide/f/README.md#:~:text=Declarative I tried a build with the tests and noticed it will involve a few other related changes. The PyPI tarball is missing the tests directory, so the Source can be switched to the GitHub tarball to get these. -Source: %{pypi_source openapi_pydantic} +# PyPI tarball is missing tests +Source: %{url}/archive/v%{version}/openapi-pydantic-%{version}.tar.gz The tests require pytest and openapi-spec-validator, which are specified in pyproject.toml as a poetry group, but unfortunately that doesn't seem to be supported by %pyproject_buildrequires yet. For now the easiest solution is to just list those dependencies manually. +BuildRequires: python3-pytest +BuildRequires: python3-openapi-spec-validator -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418666 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418666%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
