https://bugzilla.redhat.com/show_bug.cgi?id=2388154
--- Comment #9 from Gordon Messmer <[email protected]> --- (In reply to Alexander Lent from comment #7) > Spec URL: > https://gist.github.com/xanderlent/425254e3fc437b2558a3c8063b0b573a/raw/ > db2f2c06fc5299db64875dfaa4ef02a52de58724/python-tokenizers.spec I've resolved a few issues, with an alternative dist-git, here: https://codeberg.org/gordonmessmer/python-tokenizers First change: https://codeberg.org/gordonmessmer/python-tokenizers/commit/f7d1e0a44ea364cd6100f9596b9ef6f597db002c The package will not build in mock unless we disable a fairly large number of tests that require network access (including the two you had disabled in the spec, above). I've offered this change to the project (https://github.com/huggingface/tokenizers/pull/1872) though they are currently not inclined to merge the change. If you know them, maybe you'll have more luck advocating for the PR. Second change: https://codeberg.org/gordonmessmer/python-tokenizers/commit/75e082e59dc3b7ef12b327ac0d5ca3c5df9d100a This is a nit-pick: the guidelines request that we use "global" rather than "define" unless we really need to do otherwise. Third change: https://codeberg.org/gordonmessmer/python-tokenizers/commit/ed3c1a9fe16ecbc3f88111a49975969ca368b10a dev-dependencies will not be selected for dependency generation unless there is a "check" build condition, so line 1 "bcond check" is required, and that allows us to remove the manual specification of the buildreq on tempfile. cargo test requires the --no-default-features argument, as indicated in the Makefile for the "test" rule. With the addition of that argument, the tests link to libpython correctly and the tests run successfully. (Though I couldn't really explain the purpose of that flag.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388154 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388154%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
