https://bugzilla.redhat.com/show_bug.cgi?id=2383885
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <[email protected]> --- URL and Source0 are are usable. Ok. TODO: Use https schema in Source0 address. The Source0 archive (SHA-512: fa8276a7ec988e67b55ecd6d1de6b19c9cb051355495a8dc9d0a85bb4ed6201c126b3136d4e7b35258c79c01d88de74d27febfc1eb462a2a4502f0fbf180fbb2) is original. Ok. Summary and Description are Ok. License verified from lib/DBD/Cassandra/st.pm, lib/DBD/Cassandra/dr.pm, lib/DBD/Cassandra/db.pm, lib/DBD/Cassandra.pm, dist.ini, LICENSE, and README. Ok. No XS code, noarch BuildArch is Ok. Test::Pod is not used by default. Ok. BuildRequires are Ok. All tests passed. Ok. TODO: Unset AUTHOR_TESTING and CASSANDRA_HOST environment variables in %check section or delete the by default skipped tests (i.e. almost all of them) to make the tests more deterministic. $ rpmlint perl-DBD-Cassandra.spec ../SRPMS/perl-DBD-Cassandra-0.57-1.fc44.src.rpm ../RPMS/noarch/perl-DBD-Cassandra-0.57-1.fc44.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-DBD-Cassandra.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-DBD-Cassandra/LICENSE === 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-DBD-Cassandra-0.57-1.fc44.noarch.rpm drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/doc/perl-DBD-Cassandra -rw-r--r-- 1 root root 4661 Nov 27 2017 /usr/share/doc/perl-DBD-Cassandra/Changes -rw-r--r-- 1 root root 377 Nov 27 2017 /usr/share/doc/perl-DBD-Cassandra/README drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/licenses/perl-DBD-Cassandra -rw-r--r-- 1 root root 18367 Nov 27 2017 /usr/share/licenses/perl-DBD-Cassandra/LICENSE -rw-r--r-- 1 root root 4700 Jul 25 02:00 /usr/share/man/man3/DBD::Cassandra.3pm.gz -rw-r--r-- 1 root root 1083 Jul 25 02:00 /usr/share/man/man3/DBD::Cassandra::db.3pm.gz -rw-r--r-- 1 root root 1082 Jul 25 02:00 /usr/share/man/man3/DBD::Cassandra::dr.3pm.gz -rw-r--r-- 1 root root 1084 Jul 25 02:00 /usr/share/man/man3/DBD::Cassandra::st.3pm.gz drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/perl5/vendor_perl/DBD drwxr-xr-x 2 root root 0 Jul 25 02:00 /usr/share/perl5/vendor_perl/DBD/Cassandra -rw-r--r-- 1 root root 9317 Nov 27 2017 /usr/share/perl5/vendor_perl/DBD/Cassandra.pm -rw-r--r-- 1 root root 2653 Nov 27 2017 /usr/share/perl5/vendor_perl/DBD/Cassandra/db.pm -rw-r--r-- 1 root root 3183 Nov 27 2017 /usr/share/perl5/vendor_perl/DBD/Cassandra/dr.pm -rw-r--r-- 1 root root 3389 Nov 27 2017 /usr/share/perl5/vendor_perl/DBD/Cassandra/st.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-DBD-Cassandra-0.57-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(:VERSION) >= 5.10.0 1 perl(Cassandra::Client) >= 0.10 1 perl(DBD::Cassandra::db) 1 perl(DBD::Cassandra::dr) 1 perl(DBD::Cassandra::st) 1 perl(DBI) >= 1.621 1 perl(Devel::GlobalDestruction) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-DBD-Cassandra-0.57-1.fc44.noarch.rpm | sort -f | uniq -c 1 perl(DBD::Cassandra) = 0.57 1 perl(DBD::Cassandra::db) = 0.57 1 perl(DBD::Cassandra::dr) = 0.57 1 perl(DBD::Cassandra::st) = 0.57 1 perl-DBD-Cassandra = 0.57-1.fc44 Binary provides are Ok. $ resolvedeps f44-build ../RPMS/noarch/perl-DBD-Cassandra-0.57-1.fc44.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=139722596). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2383885 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202383885%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
