https://bugzilla.redhat.com/show_bug.cgi?id=2418607
Jaroslav Škarvada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #9 from Jaroslav Škarvada <[email protected]> --- Fedor, thanks for the review, some more minor things spotted: > Group: System/Libraries RPM groups are obsoleted for a long time. > Provides: %{libname}%{?_isa} = %{version}-%{release} Why to complicate things with aliases? RPM autodeps should handle it correctly. > Provides: %{upname}%{?_isa} = %{version}-%{release} Why this? If cryptoANT is the preferred name it should be named this way. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity If it isn't preferred why to complicate things with aliases? > %post > %{?ldconfig} > > > %postun > %{?ldconfig} ldconfig scriptlets are obsoleted for a long time. If you aren't packaging for older distros it doesn't make sense to include them in the new package. > * Thu Dec 04 2025 Petr Menšík <[email protected]> No version in the changelog. > cryptopant-devel.x86_64: E: incorrect-fsf-address /usr/include/cryptopANT.h You may fix it or at least open upstream ticket. Package builds OK on all supported arches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418607 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418607%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
