https://bugzilla.redhat.com/show_bug.cgi?id=2419806
--- Comment #5 from Ben Beasley <[email protected]> --- (In reply to Peter Robinson from comment #3) > > You will need to add the license files from that commit > > as additional sources for now, similar to > > https://src.fedoraproject.org/rpms/rust-fax/blob/ > > c29503f7445d80da0c868ca48af81e69408afc3c/f/rust2rpm.toml. > > Why do I need 28 lines of .toml when I can just add 2 lines in the spec file? Well, that’s not quite fair, given the amount of whitespace, commentary, and unrelated configuration in that .toml file. Something like this would suffice: [package] license-files.include = ["LICENSE"] [[package.extra-sources]] number = 10 file = "https://github.com/zowens/crc32c/raw/66c7c4905a6cf624cb1e1cbc21e7dd3cbce6faa1/LICENSE-APACHE"; [[package.extra-sources]] number = 11 file = "https://github.com/zowens/crc32c/raw/66c7c4905a6cf624cb1e1cbc21e7dd3cbce6faa1/LICENSE-MIT"; [scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."] But of course patching it in to the spec file manually is fine too. The main advantage of rust2rpm.toml is that you don’t have to repeat the exercise every time you need to re-generate the spec file, e.g. because you need to patch a dependency, but it won’t matter either way if upstream actually makes a release containing the license files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2419806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202419806%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
