https://bugzilla.redhat.com/show_bug.cgi?id=2262694
--- Comment #96 from Jonathan Steffan <[email protected]> --- (In reply to Luya Tshimbalanga from comment #92) > (In reply to Fedora Review Service from comment #91) > > Copr build: > > https://copr.fedorainfracloud.org/coprs/build/9908557 > > (succeeded) > > > > Review template: > > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > > review-2262694-materialx/fedora-rawhide-x86_64/09908557-materialx/fedora- > > review/review.txt > > > > Found issues: > > > > - License file BSD-license is not marked as %license This is actually somewhat valid. What I've done in the past is to not install -Dpm644 source/licensefile %{buildroot}%{_licensedir}/%{name}/external/licensefile but rather: * Prep all licenses into a clean location: install -Dpm644 source/licensefile licensepack/licensefile * Include the licensepack location in %files: %files %license LICENSE licensepack/* The change being that in %install you are prepping what you are going to feed to %license and then let the macros do the work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c96 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
