https://bugzilla.redhat.com/show_bug.cgi?id=2386079
--- Comment #38 from Benson Muite <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "zlib License", "MIT License", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* Apache License 2.0 and/or ISC License and/or MIT License". 167 files have unknown license. Detailed output of licensecheck in /home/benson/Projects/fedora- packaging/reviews/manifold/2386079-manifold/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14/site- packages, /usr/lib64/python3.14 [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/help/en(python3-tablib, novelwriter-doc, python-backcall- doc, python3-androguard, python3-sphinxcontrib-chapeldomain, thorvg- doc, libstrophe-doc, python3-doubleratchet, python-x3dh-docs, python3-questionary, rauc-doc, python3-cobalt, python-twomemo-docs, python-slixmpp-doc, python3-junitparser, profanity-doc, python3-colorspacious, python3-xeddsa) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package does not use a name that already exists. Note: Couldn't connect to Pagure, check manually [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 39206 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-manifold3d [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1464320 bytes in /usr/share [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 6.5 starting (python version = 3.14.0, NVR = mock-6.5-1.fc43), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results install /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/manifold-devel-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/python3-manifold3d-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/manifold-doc-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/manifold-debuginfo-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/python3-manifold3d-debuginfo-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/manifold-3.3.2-1.fc44.x86_64.rpm /home/benson/Projects/fedora-packaging/reviews/manifold/2386079-manifold/results/manifold-debugsource-3.3.2-1.fc44.x86_64.rpm Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Mock Version: 6.5 INFO: Mock Version: 6.5 Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: Package manager dnf5 detected and used (fallback) Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) Finish: chroot init INFO: installing package(s): /builddir/manifold-devel-3.3.2-1.fc44.x86_64.rpm /builddir/python3-manifold3d-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-doc-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-debuginfo-3.3.2-1.fc44.x86_64.rpm /builddir/python3-manifold3d-debuginfo-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-debugsource-3.3.2-1.fc44.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 8404a882ff0b490d92ca42e7d7a91019 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.gtngbipa:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 44 install /builddir/manifold-devel-3.3.2-1.fc44.x86_64.rpm /builddir/python3-manifold3d-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-doc-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-debuginfo-3.3.2-1.fc44.x86_64.rpm /builddir/python3-manifold3d-debuginfo-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-3.3.2-1.fc44.x86_64.rpm /builddir/manifold-debugsource-3.3.2-1.fc44.x86_64.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Rpmlint ------- Checking: manifold-3.3.2-1.fc44.x86_64.rpm manifold-devel-3.3.2-1.fc44.x86_64.rpm python3-manifold3d-3.3.2-1.fc44.x86_64.rpm manifold-doc-3.3.2-1.fc44.x86_64.rpm manifold-3.3.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc0f0fqaf')] checks: 32, packages: 5 manifold-doc.x86_64: W: no-documentation python3-manifold3d.x86_64: W: no-documentation manifold-doc.x86_64: E: no-binary manifold.spec:67: W: comparison-operator-in-deptoken %{name}%{?_isa}=%{version}-%{release} 5 packages and 0 specfiles checked; 1 errors, 3 warnings, 34 filtered, 1 badness; has taken 2.1 s Unversioned so-files -------------------- python3-manifold3d: /usr/lib64/python3.14/site-packages/manifold3d.cpython-314-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/elalish/manifold/archive/v3.3.2/manifold-3.3.2.tar.gz : CHECKSUM(SHA256) this package : 92a37034c407156f71446f9ca03bd4487adeb1b8246a03d1c047b859b1b9d211 CHECKSUM(SHA256) upstream package : 92a37034c407156f71446f9ca03bd4487adeb1b8246a03d1c047b859b1b9d211 Requires -------- manifold (rpmlib, GLIBC filtered): libClipper2.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmanifold.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.12()(64bit) rtld(GNU_HASH) manifold-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libmanifold.so.3()(64bit) libmanifoldc.so.3()(64bit) manifold(x86-64) python3-manifold3d (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libmanifold.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) manifold(x86-64)=3.3.2-1.fc44 python(abi) python3.14dist(numpy) rtld(GNU_HASH) manifold-doc (rpmlib, GLIBC filtered): Provides -------- manifold: libmanifold.so.3()(64bit) libmanifoldc.so.3()(64bit) manifold manifold(x86-64) manifold-devel: cmake(manifold) manifold-devel manifold-devel(x86-64) pkgconfig(manifold) python3-manifold3d: bundled(libnanobind) python-manifold3d python3-manifold3d python3-manifold3d(x86-64) python3.14-manifold3d python3.14dist(manifold3d) python3dist(manifold3d) manifold-doc: manifold-doc manifold-doc(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2386079 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Haskell, Java, fonts, Perl, SugarActivity, Ocaml, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: 1) Please change # Feature toggles: Python bindings enabled by default %bcond python 1 to # Feature toggles: Python bindings disabled by default # until fixed upstream %bcond python 0 2) Other than that it seems ok. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386079 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386079%23c38 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
