https://bugzilla.redhat.com/show_bug.cgi?id=2417682
Sergio Correia <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Sergio Correia <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= No blocking issues found. All MUST items pass. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Package builds successfully in copr-build 9923598 [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: Verified MIT License. License file at /tmp/scientific-0.5.2/LICENSE contains standard MIT License text with copyright (c) 2021 ALeX Kazik. Package provides arbitrary precision scientific number calculations in pure Rust, no_std capable. Mathematical library for scientific notation operations. [x]: License field in the package spec file matches the actual license. Note: Spec declares "License: MIT" which matches the actual MIT License in the LICENSE file. The licensecheck output shows 60 files with "Unknown or generated" license, but these are all source code files (.rs), configuration files (Cargo.toml, .cargo_vcs_info.json, .cargo- rdme.toml), and documentation (README.md, Changelog.md) which is normal - they are covered under the project's MIT License. The LICENSE file itself is correctly identified as "MIT License" by licensecheck. [x]: License file installed when any subpackage combination is installed. Note: %license directive in spec line 33 ensures LICENSE is installed: %license %{crate_instdir}/LICENSE [x]: %build honors applicable compiler flags or justifies otherwise. Note: Uses %cargo_build macro which properly handles Rust compiler flags. [x]: Package contains no bundled libraries without FPC exception. Note: Rust package with declared dependencies via Cargo. Only runtime dependency is scientific-macro (version 0.5.2, optional). All other dependencies (num-integer, postcard, rand, serde_json) are dev-only. [x]: Changelog in prescribed format. Note: Uses %autochangelog macro for automatic changelog generation. [x]: Sources contain only permissible code or content. Note: Examined source code in /tmp/scientific-0.5.2/. Package is a legitimate arbitrary precision scientific number library. Provides mathematical operations (addition, subtraction, multiplication, division, square root, rounding, truncation) with arbitrary precision. Source files reviewed include lib.rs, types/scientific.rs, math/*.rs, conversion/*.rs. Code is pure Rust, no_std capable, implementing arbitrary precision arithmetic. No malware or suspicious code found. [x]: Package contains desktop file if it is a GUI application. Note: Library package, not a GUI application. [x]: Development files must be in a -devel package Note: This is a Rust -devel package containing library source for building other packages. [x]: Package uses nothing in %doc for runtime. Note: Only Changelog.md and README.md are marked as %doc which are documentation only. [x]: Package consistently uses macros (instead of hard-coded directory names). Note: Properly uses %{crate_instdir} and other standard Rust macros. [x]: Package is named according to the Package Naming Guidelines. Note: Follows Rust packaging naming: rust-scientific [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. Note: Installs to %{crate_instdir} which is /usr/share/cargo/registry/scientific-0.5.2/ [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. Note: Not a renamed package. [x]: Requires correct, justified where necessary. Note: Main -devel package requires only cargo and rust. Feature packages have appropriate dependencies (scientific-macro for macro feature, serde for serde feature). [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. Note: Library package, no systemd files needed. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: LICENSE file included via %license directive. [x]: The License field must be a valid SPDX expression. Note: "MIT" is a valid SPDX license identifier. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. Note: Uses %cargo_install macro. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. Note: Checksum verified below. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: rust-scientific.spec matches package name. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files (only README.md and Changelog.md). [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. Note: Package built in copr, which uses mock. Built locally with mock for rawhide as well. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: LICENSE file is included in upstream source. [x]: Final provides and requires are sane (see attachments). Note: Provides include crate(scientific) and feature-specific provides (default, arc, debug, macro, scientific-macro, serde, std). Requires are appropriate for the crate's features. [-]: Fully versioned dependency in subpackages if applicable. Note: Rust feature packages use crate() dependencies without %{name} %{?_isa} versioning, which is normal and correct for Rust packages. The crate() virtual provides system handles versioning appropriately. [x]: Package functions as described. Note: Arbitrary precision scientific number library, no_std capable, in pure Rust. Provides mathematical operations with arbitrary precision including addition, subtraction, multiplication, division, square root, rounding, and truncation. [x]: Latest version is packaged. Note: Version 0.5.2 appears to be the latest version available on crates.io. The package was last updated approximately 2 years ago and remains the current version. [x]: Package does not include license text files separate from upstream. Note: LICENSE file is from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. Note: No patches applied. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: crates.io does not provide GPG signatures. [-]: Package should compile and build into binary rpms on all supported architectures. Note: BuildArch: noarch - Rust source packages are architecture independent. [x]: %check is present and all tests pass. Note: Tests are enabled with %bcond check 1, which means tests run during build. This is excellent for a mathematical library. [x]: Packages should try to preserve timestamps of original installed files. Note: cargo-rpm-macros handle this. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-scientific-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+default-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+arc-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+debug-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+macro-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+scientific-macro-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+serde-devel-0.5.2-1.fc44.noarch.rpm rust-scientific+std-devel-0.5.2-1.fc44.noarch.rpm rust-scientific-0.5.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpomhpvh4p')] checks: 32, packages: 9 9 packages and 0 specfiles checked; 0 errors, 0 warnings, 49 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-scientific+default-devel". (none): E: there is no installed rpm "rust-scientific+arc-devel". (none): E: there is no installed rpm "rust-scientific+std-devel". (none): E: there is no installed rpm "rust-scientific+scientific-macro-devel". (none): E: there is no installed rpm "rust-scientific+macro-devel". (none): E: there is no installed rpm "rust-scientific+debug-devel". (none): E: there is no installed rpm "rust-scientific-devel". (none): E: there is no installed rpm "rust-scientific+serde-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/scientific/0.5.2/download#/scientific-0.5.2.crate : CHECKSUM(SHA256) this package : dc53198b8e237c451c68dba8411a1f8bd92787657689f24d67ae3d6b98c39f59 CHECKSUM(SHA256) upstream package : dc53198b8e237c451c68dba8411a1f8bd92787657689f24d67ae3d6b98c39f59 Checksums match. Requires -------- rust-scientific-devel (rpmlib, GLIBC filtered): cargo rust rust-scientific+default-devel (rpmlib, GLIBC filtered): cargo crate(scientific) crate(scientific/macro) rust-scientific+arc-devel (rpmlib, GLIBC filtered): cargo crate(scientific) rust-scientific+debug-devel (rpmlib, GLIBC filtered): cargo crate(scientific) rust-scientific+macro-devel (rpmlib, GLIBC filtered): cargo crate(scientific) crate(scientific/scientific-macro) rust-scientific+scientific-macro-devel (rpmlib, GLIBC filtered): (crate(scientific-macro/default) >= 0.5.2 with crate(scientific-macro/default) < 0.6.0~) cargo crate(scientific) rust-scientific+serde-devel (rpmlib, GLIBC filtered): (crate(serde/default) >= 1.0.16 with crate(serde/default) < 2.0.0~) cargo crate(scientific) rust-scientific+std-devel (rpmlib, GLIBC filtered): cargo crate(scientific) Provides -------- rust-scientific-devel: crate(scientific) rust-scientific-devel rust-scientific+default-devel: crate(scientific/default) rust-scientific+default-devel rust-scientific+arc-devel: crate(scientific/arc) rust-scientific+arc-devel rust-scientific+debug-devel: crate(scientific/debug) rust-scientific+debug-devel rust-scientific+macro-devel: crate(scientific/macro) rust-scientific+macro-devel rust-scientific+scientific-macro-devel: crate(scientific/scientific-macro) rust-scientific+scientific-macro-devel rust-scientific+serde-devel: crate(scientific/serde) rust-scientific+serde-devel rust-scientific+std-devel: crate(scientific/std) rust-scientific+std-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --copr-build 9923598 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, Perl, C/C++, R, PHP, Ocaml, Java, Python, Haskell, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH ===== APPROVAL ===== This package is APPROVED, thanks. No issues, all MUST items pass. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417682 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417682%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
