https://bugzilla.redhat.com/show_bug.cgi?id=2424184
--- Comment #4 from Vít Ondruch <[email protected]> --- Since I am already looking: # The description refers to `minitest/unit` on several places The new upstream description was modified to `minitest/test` # Not required `BuildRequires: rubygem(hoe)` I don't think `hoe` is required for build. It can be safely dropped IMHO. # Use standardized `gem build ../%{gem_name}-%{version}.gemspec` There is `mv ../%{gem_name}-%{version}.gemspec .` in `%prep` section later followed by `gem build %{gem_name}-%{version}.gemspec`. The `gem2rpm` would leave the `mv` and used `../%{gem_name}-%{version}.gemspec` in the `gem build` step. # Leave tests and other files in -doc subpackage I would leave the tests and other files in -doc subpacakge. They won't hurt IMHO. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2424184 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202424184%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
