https://bugzilla.redhat.com/show_bug.cgi?id=2416903
--- Comment #3 from Benson Muite <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "BSD 3-Clause License", "*No copyright* The Unlicense", "zlib License", "*No copyright* Apache License and/or Creative Commons Attribution-ShareAlike 4.0 and/or SIL Open Font License 1.1 and/or zlib License", "MIT License and/or The Unlicense". 802 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/vst3sdk/2416903- vst3sdk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 374970 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vst3sdk- hosting , vst3sdk-common , vst3sdk-tools [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vst3sdk-3.8.0-1.fc44.x86_64.rpm vst3sdk-hosting-3.8.0-1.fc44.x86_64.rpm vst3sdk-common-3.8.0-1.fc44.x86_64.rpm vst3sdk-devel-3.8.0-1.fc44.x86_64.rpm vst3sdk-tools-3.8.0-1.fc44.x86_64.rpm vst3sdk-3.8.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr1kj0btu')] checks: 32, packages: 6 vst3sdk-common.x86_64: W: package-with-huge-docs 61% vst3sdk.x86_64: W: no-documentation vst3sdk-devel.x86_64: W: no-documentation vst3sdk-hosting.x86_64: W: no-documentation vst3sdk.spec: W: no-%check-section 6 packages and 0 specfiles checked; 0 errors, 5 warnings, 39 filtered, 0 badness; has taken 2.5 s Rpmlint (debuginfo) ------------------- Checking: vst3sdk-tools-debuginfo-3.8.0-1.fc44.x86_64.rpm vst3sdk-hosting-debuginfo-3.8.0-1.fc44.x86_64.rpm vst3sdk-debuginfo-3.8.0-1.fc44.x86_64.rpm vst3sdk-common-debuginfo-3.8.0-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpszg4ttg3')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 vst3sdk-common.x86_64: W: package-with-huge-docs 61% vst3sdk.x86_64: W: no-documentation vst3sdk-devel.x86_64: W: no-documentation vst3sdk-hosting.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 0 errors, 4 warnings, 70 filtered, 0 badness; has taken 2.5 s Source checksums ---------------- https://github.com/steinbergmedia/vst3sdk/archive/v3.8.0_build_66/vst3sdk-3.8.0.tar.gz : CHECKSUM(SHA256) this package : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4 CHECKSUM(SHA256) upstream package : d93c12077d848977d4d397c8ab6721c4b4966223a7707bfe6519aa419c396af4 https://github.com/steinbergmedia/vst3_base/archive/v3.8.0_build_66/vst3_base-3.8.0.tar.gz : CHECKSUM(SHA256) this package : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6 CHECKSUM(SHA256) upstream package : 001ef3dccf89505ee624766c8140c6c845fbd214460e02ea16145db29f1e2ed6 https://github.com/steinbergmedia/vst3_cmake/archive/v3.8.0_build_66/vst3_cmake-3.8.0.tar.gz : CHECKSUM(SHA256) this package : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4 CHECKSUM(SHA256) upstream package : 7e252775d662f13f5ecf7671e44db947f793767926d87b3d482391e9a76406b4 https://github.com/steinbergmedia/vst3_pluginterfaces/archive/v3.8.0_build_66/vst3_pluginterfaces-3.8.0.tar.gz : CHECKSUM(SHA256) this package : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4 CHECKSUM(SHA256) upstream package : c922f0a35f2c093dfcb24ccd95282e70d00cc2de42fc0c8ac1577398ffe7b6d4 https://github.com/steinbergmedia/vst3_public_sdk/archive/v3.8.0_build_66/vst3_public_sdk-3.8.0.tar.gz : CHECKSUM(SHA256) this package : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f CHECKSUM(SHA256) upstream package : 83b64e6666a54a35a2292a73ef35048b6d0dadd5e50a22cb437ac4cfb69ba81f Requires -------- vst3sdk (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvst3sdk_common.so.0()(64bit) rtld(GNU_HASH) vst3sdk-common(x86-64) vst3sdk-hosting (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvst3sdk_common.so.0()(64bit) rtld(GNU_HASH) vst3sdk-common(x86-64) vst3sdk-common (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) vst3sdk-devel (rpmlib, GLIBC filtered): libvst3sdk.so.0()(64bit) libvst3sdk_common.so.0()(64bit) libvst3sdk_hosting.so.0()(64bit) vst3sdk(x86-64) vst3sdk-common(x86-64) vst3sdk-hosting(x86-64) vst3sdk-tools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvst3sdk_common.so.0()(64bit) libvst3sdk_hosting.so.0()(64bit) rtld(GNU_HASH) vst3sdk-hosting(x86-64) Provides -------- vst3sdk: libvst3sdk.so.0()(64bit) vst3sdk vst3sdk(x86-64) vst3sdk-hosting: libvst3sdk_hosting.so.0()(64bit) vst3sdk-hosting vst3sdk-hosting(x86-64) vst3sdk-common: libvst3sdk_common.so.0()(64bit) vst3sdk-common vst3sdk-common(x86-64) vst3sdk-devel: vst3sdk-devel vst3sdk-devel(x86-64) vst3sdk-tools: vst3sdk-tools vst3sdk-tools(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2416903 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, R, fonts, SugarActivity, Ocaml, Haskell, PHP, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140414283 b) Can files with other license be removed prior to the build step? In particular https://github.com/steinbergmedia/vst3_public_sdk/tree/a3911a4615dabbfdfd9d181ee26b05c70c289a95/samples/vst/dataexchange/source/3rdparty c) Is it possible to upstream patch with option to create a shared library? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2416903 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416903%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
