https://bugzilla.redhat.com/show_bug.cgi?id=2337168

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #14 from Neal Gompa <[email protected]> ---
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Licensing is correct and license file is installed
* No serious issues from rpmlint

Issue to resolve before importing:

- Add %check section that runs desktop-file-validate on all desktop files
installed into %{_datadir}/applications.

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2337168

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202337168%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to