https://bugzilla.redhat.com/show_bug.cgi?id=2423802
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|[email protected] |[email protected] Status|NEW |POST CC| |[email protected] --- Comment #4 from Fabio Valentini <[email protected]> --- Package looks good to me, with a few minor things that I trust you can address before importing: - Exclude the scripts/ folder from the package. It causes a dependency on /bin/bash. - Maybe also exclude the tests/files folder. It contains only test input files. - Similarly, Justfile and release.toml are only valuable for upstream development. An exclusion rule for .cargo/, scripts/, Justfile, and release.toml might be acceptable for upstream too. === Package was generated with rust2rpm, simplifying the review. The downstream Cargo.toml patch is justified and documented. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2423802 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202423802%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
