https://bugzilla.redhat.com/show_bug.cgi?id=2408803
--- Comment #6 from Shek Yun Kwan <[email protected]> --- Hi, thank you for the package review! Regarding the comments: e) There is a test for the GUI during the build, so I guess it can be assumed to be built if it passes? It does seem to pass, at least on non s390x. g) The s390x issue used to be tracked here(https://github.com/davisking/dlib/issues/2947) and the fix is merged. It seems that the previous maintainer decided to just disable s390x and probably never got around to fixing it, and upstream seems to be saying they are unable to debug it? Unfortunately I don't really know how to fix it, and I doubt upstream wants to do that given the project owner says "But I don't know if anyone is using it on s390x. Maybe the tests are just overly tight numerically?" (https://github.com/davisking/dlib/issues/2947#issuecomment-2081475292). h) I don't know how to do this. I assume this isn't something I can just add to the spec file? The rest of the corrections are done in the updated spec file and srpm here: Spec URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/fedora-review/dlib.spec SRPM URL: https://github.com/ykshek/dlib-copr-specs/raw/refs/heads/fedora-review/dlib-20.0-1.fc43.src.rpm A test build is done here: https://copr.fedorainfracloud.org/coprs/starfish/dlib/build/9957347/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2408803 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202408803%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
