https://bugzilla.redhat.com/show_bug.cgi?id=2425662
--- Comment #3 from Neal Gompa <[email protected]> --- Spec review: > # Important Note: This is an application using KDE frameworks, > # but it is not an official KDE project This literally doesn't matter, drop it. > Name: Kontainer It's preferred that we use lowercase here. > Source0: %{url}/archive/refs/tags/%{version}.tar.gz This should use the proper SourceURL form for GitHub: "%{url}/archive/%{version}/%{name}-%{version}.tar.gz" (This works once you update to lowercase name.) > %find_lang kontainer > [...] > %files -f kontainer.lang This can use %{name} once the package name is changed to lowercase. Other spec notes: This package requires a dependency on "distrobox" as it doesn't support toolbx yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2425662 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202425662%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
