https://bugzilla.redhat.com/show_bug.cgi?id=2425821
--- Comment #2 from Michel Lind <[email protected]> --- Some issues with directory ownership, see below, but most concernedly it's the CC0-1.0 license. Per the REUSE.toml it only affects docs/metadata (README.md and Cargo.lock) so it *should* be fine, but it's still very weird having Cargo.lock, which is a generated artifact, be... versioned. In any case you might want to ship REUSE.toml as %license too and have a comment mentioning that no code is CC0-1.0 Also note Fabio's comment in chat that you don't need to turn off Cargo's network access explicitly. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in dynamic-hibernate See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 2-Clause License", "GNU General Public License, Version 2", "Unknown or generated", "*No copyright* BSD 2-Clause License", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3". 4 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/dynamic- hibernate/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. can you add the comment that cargo2rpm generates below the License field? see below: # LICENSE.dependencies contains a full license breakdown [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/systemd/sleep.conf.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1/system.d, /usr/lib/systemd/sleep.conf.d, /usr/lib/systemd/system/systemd- logind.service.d, /usr/share/dbus-1 nothing seems to own sleep.conf.d so you might want to claim it systemd-logind.service.d is currently owned by grub2-tools, so I suspect it's another that you should just claim too /usr/share/dbus-1 should be dbus-common [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. see CC0-1.0 note above [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. see directory ownership [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in dynamic-hibernate [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1093 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dynamic-hibernate-0.1.0~git20251209.aaf963c-1.fc44.x86_64.rpm dynamic-hibernate-0.1.0~git20251209.aaf963c-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2wvnyoxg')] checks: 32, packages: 2 dynamic-hibernate.src: E: spelling-error ('swapfile', 'Summary(en_US) swapfile -> swap file, swap-file, swapped') dynamic-hibernate.src: E: spelling-error ('swapfiles', '%description -l en_US swapfiles -> swap files, swap-files, swaddles') dynamic-hibernate.src: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d') dynamic-hibernate.src: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') dynamic-hibernate.src: E: spelling-error ('swapfile', '%description -l en_US swapfile -> swap file, swap-file, swapped') dynamic-hibernate.x86_64: E: spelling-error ('swapfile', 'Summary(en_US) swapfile -> swap file, swap-file, swapped') dynamic-hibernate.x86_64: E: spelling-error ('swapfiles', '%description -l en_US swapfiles -> swap files, swap-files, swaddles') dynamic-hibernate.x86_64: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') dynamic-hibernate.x86_64: E: spelling-error ('swapfile', '%description -l en_US swapfile -> swap file, swap-file, swapped') dynamic-hibernate.spec: W: no-%check-section dynamic-hibernate.x86_64: E: incorrect-fsf-address /usr/share/licenses/dynamic-hibernate/GPL-2.0-only.txt dynamic-hibernate.x86_64: W: incoherent-version-in-changelog 0.1.0~git20251209.aaf963c-2 ['0.1.0~git20251209.aaf963c-1.fc44', '0.1.0~git20251209.aaf963c-1'] dynamic-hibernate.x86_64: E: dbus-policy-allow-without-destination <allow send_interface="org.dynamic_hibernate.DynamicHibernate"/> /usr/share/dbus-1/system.d/org.dynamic_hibernate.DynamicHibernate.conf dynamic-hibernate.x86_64: W: dbus-policy-allow-receive <allow receive_sender="org.dynamic_hibernate.DynamicHibernate"/> /usr/share/dbus-1/system.d/org.dynamic_hibernate.DynamicHibernate.conf 2 packages and 0 specfiles checked; 11 errors, 3 warnings, 11 filtered, 11 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: dynamic-hibernate-debuginfo-0.1.0~git20251209.aaf963c-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp10yijp0l')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 1.9 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "dynamic-hibernate-debuginfo". (none): E: there is no installed rpm "dynamic-hibernate". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://invent.kde.org/tduck/dynamic-hibernate/-/archive/aaf963c95b30b9afb2b3749bb078f973ac3ab19a/dynamic-hibernate-aaf963c.tar.gz : CHECKSUM(SHA256) this package : 8e9c5777e732316ec6d3088bf1b39abcf407f88f52f66be2720da41979f2cefe CHECKSUM(SHA256) upstream package : 8e9c5777e732316ec6d3088bf1b39abcf407f88f52f66be2720da41979f2cefe Requires -------- dynamic-hibernate (rpmlib, GLIBC filtered): /bin/sh ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) rtld(GNU_HASH) Provides -------- dynamic-hibernate: dynamic-hibernate dynamic-hibernate(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name dynamic-hibernate --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Perl, Haskell, Ocaml, Python, C/C++, R, PHP, SugarActivity, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2425821 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202425821%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
