https://bugzilla.redhat.com/show_bug.cgi?id=1684603
--- Comment #41 from Jaroslav Škarvada <[email protected]> --- Repackaged according to the new Python packaging guidelines. > a) Fastclick has been archived: https://github.com/ftlabs/fastclick > It seems ok to bundle, though packaging it separately would be ideal. Where > else is it used in Fedora? > Maybe someone may want to maintain it? Here it seems some customized version of the fastclick is used, probably based on the version 1.0.6, but re-formatted at least, so I didn't add the bundled version tag, because it's probably now a fork. > b) SVGcode seemps to be maintained in the repository > https://github.com/vlachoudis/bCNC/tree/master/bCNC/lib > There is a related project on Pypi https://github.com/PadLex/SvgToGcode but > this is not the one that is used It's in the bCNC repo, i.e. no separate repo exists. We could build the lib subpackage from the bCNC package if there are some consumers, but probably not worth the effort if we are the only consumer. > c) The repository has text for MIT and BSD licenses, > https://github.com/vlachoudis/bCNC can these be included? Added to the license tag. > d) In the spec file, perhaps also add information that the compat folder > includes bytecode, that is why it is removed. Added. > e) There is a smoke test https://github.com/vlachoudis/bCNC/tree/master/tests > can this be run? There are unsatisfied deps, e.g. pyautogui, so kept it temporally disabled until this package is available in Fedora. Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec SRPM URL: https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-6.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1684603 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201684603%23c41 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
