https://bugzilla.redhat.com/show_bug.cgi?id=2372509
--- Comment #6 from Neal Gompa <[email protected]> --- Initial spec review notes: > Source0: %{url}/+archive/v%{version}.tar.gz Please make this a named tarball like so: "%{url}/+archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz" > Source1: > https://chromium.googlesource.com/linux-syscall-support/+archive/v2024.02.01.tar.gz Please make this a named tarball like so: "https://chromium.googlesource.com/linux-syscall-support/+archive/v2024.02.01.tar.gz/#linux-syscall-support-2024.02.01.tar.gz"; You may want to make a macro for the version so you can centrally control it. My suggestion is to set "%{lss_version}" at the top of the spec and use it in here. > tar xf %{SOURCE0} > mkdir -p src/third_party/lss > tar xf %{SOURCE1} -C src/third_party/lss Please use one of the setup macros for Source0, as it also does some background setup stuff for the build environment. Here's my suggestion: %autosetup -C tar xvf %{SOURCE1} -C src/third_party/lss (tar will create the directories for you) > %build > export CXXFLAGS="$CXXFLAGS -Wno-error=array-bounds -Wno-maybe-uninitialized" > %configure > %make_build Configure step should be split into the %conf stage unless you plan to support EPEL9 or older. This is what it would look like: %conf export CXXFLAGS="$CXXFLAGS -Wno-error=array-bounds -Wno-maybe-uninitialized" %configure %build %make_build > %ifarch x86_64 %{ix86} Please use "%{x86_64}" for x86_64, as it covers all subarches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2372509 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202372509%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
