https://bugzilla.redhat.com/show_bug.cgi?id=2427087
--- Comment #11 from Sam Day <[email protected]> --- Latest (final? :D) revision: Spec URL: https://samcday.fedorapeople.org/phrog.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3007/141093007/phrog-0.50.0-1.fc44.src.rpm --- > I. It would be great if you could a) use the "SourceLicense" tag to specify > which license "phrog" itself is distributed under (right now the "License" > tag only applies to the built package) and / or add a short comment to say > "phrog license is FOO, licenses of statically linked Rust dependencies are > thus: ...". Cool, makes sense - I've done that in latest revision. > II. The License tag looks correct, though it is not "minimal". In this case, > the difference is negligible, so you could just leave it as-is (but in > theory, you could drop the "(MIT OR Apache-2.0)" line because that's already > covered by "(Apache-2.0 OR MIT)" - but I think this is even the only one > that's "duplicated" here, you it wouldn't gain you much in terms of > readability, and you would lose out on being able to mostly copy-paste from > the %cargo_license_summary output). So I would say whether you want to > "minimize" the License tag in this way is entirely up to you in this case. If this was the only remaining feedback I'd have just said "naw all good, let's ideally have `%cargo_license_summary` output handle alphabetize + de-dupe someday" :D. But, the simplification is in this latest revision instead. > III. The .desktop file validation is missing from the latest version > (expected - should be fixed either in the next version or before importing > the package). It's in this one. > IV. You're generating the "vendor manifest", but that file is not actually > used anywhere. You'll need to add `%license cargo-vendor.txt` as a file to > the %files list. The RPM generator for `bundled(crate(...))` generator is > triggered by the presence (and contents) of this file. Ah, fixed. I confirm that `rpm -q --provides` on the latest rpm has all the `bundled(crate(...))` bits. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2427087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202427087%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
