https://bugzilla.redhat.com/show_bug.cgi?id=2430668



--- Comment #3 from Neal Gompa <[email protected]> ---
It seems the bot can't figure out how to deal with your URLs. FYI, as a
packager, you have access to your own fedorapeople.org space. And
alternatively, you can also use COPR as well to "host" something that the bots
can read.

Initial spec review

> Source0:        
> https://github.com/hoshinolina/obs-pwvideo/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz

This can be simplified to
"%{url}/archive/%{version_no_tilde}/obs-pwvideo-%{version_no_tilde}.tar.gz"

> %setup -q -n obs-pwvideo-%{version_no_tilde}

Please use "%autosetup" in place of "%setup -q". 

But also as a further optimization, you can use the relatively new "%autosetup
-C" instead of "%autosetup -n obs-pwvideo-%{version_no_tilde}" as long as you
don't intend to backport it to RHEL via EPEL.

(there's an open backport request for EPEL 10, but at the moment, it is not yet
available)

> %build
> %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
>        -GNinja
>
> %cmake_build

Please split this out into a %conf stage unless you intend to backport this to
EPEL 9. Such a split looks like this:

%conf
%cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
       -GNinja

%build
%cmake_build


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2430668

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202430668%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to