https://bugzilla.redhat.com/show_bug.cgi?id=2430592

Miroslav Suchý <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #4 from Miroslav Suchý <[email protected]> ---
> License:        Unknown

You should identify the license. Please see
https://docs.fedoraproject.org/en-US/legal/license-field/

> udevadm control --reload > /dev/null 2>&1 || :

Should rather be:

if [ -S /run/udev/control ]; then
    udevadm control --reload
    udevadm trigger
fi

> %defattr(644,root,root,755)

This is the default. You can remove this line.

> shopt -s nullglob

This is very uncommon. And if I read the code correctly, it is not needed.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2430592

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202430592%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to