https://bugzilla.redhat.com/show_bug.cgi?id=2416340



--- Comment #17 from Fabio Valentini <[email protected]> ---
Looks mostly OK, two minor issues:

1) Contains media files in media/* that looks like images that are embedded in
README when rendered to HTML.
   It would make sense to exclude those from the built packages (and possibly
even upstream, from published crates).

2) You must use "rust2rpm -p" to edit the contents of Cargo.toml.
   The final contents of Cargo.toml must be known to generate correct .spec
files,
   so edits *cannot* be made manually with tools like sed or tomcli (unless you
*really really* know what you're doing).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2416340

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416340%23c17

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to