https://bugzilla.redhat.com/show_bug.cgi?id=2430840

Mikel Olasagasti Uranga <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #9 from Mikel Olasagasti Uranga <[email protected]> ---
> %{_mandir}/man1/*

It should be %{_mandir}/man1/rhc.1*

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

> %if 0%{?fedora}
> Recommends: insights-client

AFAIK the package doesn't exist in Fedora, it can't be recommended.

> BuildRequires:  pkgconfig(bash-completion)

What for?

> %{_datadir}/bash-completion/completions/rhc

Use:

%{bash_completions_dir}/%{name}

> BuildRequires:  make

Is it used?

> BuildRequires:  pkgconfig(systemd)

Is it required?

> BuildRequires:  golang
> BuildRequires:  go-rpm-macros

These are pulled by go macros, could be removed

I see the package has been imported already, but would be great if you could
fix reported issues. I'm writing here so Link also can see what was missing.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2430840

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202430840%23c9

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to