https://bugzilla.redhat.com/show_bug.cgi?id=2431593
--- Comment #2 from Yaakov Selkowitz <[email protected]> --- The spec file should be named clevis-pin-trustee.spec (no "-fedora"). Also, please fix the permissions on your spec file so it can be viewed. Drop %global debug_package %{nil}. That is for rust crate "libraries", where this is a real binary which should have debuginfo. The rust-packaging name is old; use BuildRequires: cargo-rpm-macros instead. Any reason not to use rpmautospec? There should be a comment stating why BuildRequires: rust-tempfile+default-devel is necessary, as generally %cargo_generate_buildrequires should handle all such deps. As this produces a binary, %cargo_license_summary and %cargo_license need to be used as documented at https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ . This will also affect the License tag. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2431593 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431593%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
