https://bugzilla.redhat.com/show_bug.cgi?id=2431166
--- Comment #1 from Miro Hrončok <[email protected]> --- Spec sanity: The spec is perfectly sane, thank you! :) Diff sanity against python-roman-numerals-py. -Name: python-roman-numerals-py -Version: 3.1.0 +Name: python-roman-numerals +Version: 4.1.0 Obviously good. -Source: %{pypi_source roman_numerals_py} +Source: %{pypi_source roman_numerals} Same here. +BuildRequires: python3-pytest This surprised me; the specfile no longer uses the [test] extra for this. Upstream still has it, and only "pytest>=9" is in it, so I suppose this is a way to avoid the >=9 part? I do not entirely like it this way, although it is arguably much simpler than patching the version pin. Perhaps add a comment above the requirement? (Something along the lines of: Upstream has the [test] extra, but it needlessly declares the minimal pytest version and depends on nothing else.) -%package -n python3-roman-numerals-py +%package -n python3-roman-numerals Summary: %{summary} -%description -n python3-roman-numerals-py %_description +Provides: python3-roman-numerals-py = %{version}-%{release} +Obsoletes: python3-roman-numerals-py < 3.1.0-7 + +%description -n python3-roman-numerals %_description Obvious renames. Please use %py_provides instead of Provides, so it also provides python-roman-numerals-py and python3.14-roman-numerals-py (it also removes the need to specify the version to provide). Considering the version difference, perhaps Obsolete < 4~~, so if by any chance a hotfix 3.1.1 is released (unlikely), and we update to it in Fedora 43, this Obsoletes does not need to be updated. %prep -%autosetup -p1 -n roman_numerals_py-%{version} +%autosetup -p1 -n roman_numerals-%{version} Obvious. %generate_buildrequires -%pyproject_buildrequires -x test +%pyproject_buildrequires Already addressed above. -%files -n python3-roman-numerals-py -f %{pyproject_files} +%files -n python3-roman-numerals -f %{pyproject_files} Obvious. --- Note: As this package installs a roman_numerals module, it should normally Conflict with the older one, but considering it Obsoletes it, all is good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2431166 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431166%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
