https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #33 from Benson Muite <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3", "MIT License". 72 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/badfish/2268405- badfish/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 39223 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: badfish-1.0.6-git.20251020_123704.fc44.noarch.rpm badfish-1.0.6-git.20251020_123704.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc14zizam')] checks: 32, packages: 2 badfish.noarch: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API badfish.src: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API badfish.noarch: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') badfish.src: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') badfish.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/badfish/main.py 644 /usr/bin/env python3 badfish.noarch: W: no-manual-page-for-binary badfish badfish.noarch: W: name-repeated-in-summary Badfish badfish.src: W: name-repeated-in-summary Badfish 2 packages and 0 specfiles checked; 5 errors, 3 warnings, 7 filtered, 5 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 badfish.noarch: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API badfish.noarch: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') badfish.noarch: E: non-executable-script /usr/lib/python3.14/site-packages/badfish/main.py 644 /usr/bin/env python3 badfish.noarch: W: no-manual-page-for-binary badfish badfish.noarch: W: name-repeated-in-summary Badfish 1 packages and 0 specfiles checked; 3 errors, 2 warnings, 3 filtered, 3 badness; has taken 0.1 s Source checksums ---------------- https://github.com/redhat-performance/badfish/releases/download/v1.0.6/badfish-1.0.6.tar.gz : CHECKSUM(SHA256) this package : 6f877cc1d8a04d9798a6fc7c4594411cffa71352db0259cac5375a93aeeb3dce CHECKSUM(SHA256) upstream package : 6f877cc1d8a04d9798a6fc7c4594411cffa71352db0259cac5375a93aeeb3dce Requires -------- badfish (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.14dist(aiohttp) python3.14dist(pyyaml) python3.14dist(setuptools) Provides -------- badfish: badfish python3.14dist(badfish) python3dist(badfish) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2268405 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: PHP, Haskell, fonts, R, Ocaml, C/C++, Perl, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please shorten the summary, perhaps: Tool for managing bare-metal systems via the Redfish API is sufficient b) Most dependencies other than test dependencies can be automatically generated. Tox is not needed. Please change BuildArch: noarch BuildRequires: %{py3_dist setuptools} BuildRequires: %{py3_dist pip} BuildRequires: python3-devel BuildRequires: zlib-devel BuildRequires: python3dist(pytest) BuildRequires: python3dist(pytest-asyncio) BuildRequires: python3dist(pyyaml) BuildRequires: python3dist(aiohttp) BuildRequires: python3dist(tox) Provides: badfish = %{version}-%{release} %generate_buildrequires %pyproject_buildrequires %description %{desc} %prep %autosetup -n %{name}-%{version} %build to BuildArch: noarch BuildRequires: python3-devel BuildRequires: zlib-devel BuildRequires: python3dist(pytest) BuildRequires: python3dist(pytest-asyncio) BuildRequires: python3dist(pyyaml) BuildRequires: python3dist(aiohttp) Provides: badfish = %{version}-%{release} %description %{desc} %prep %autosetup -n %{name}-%{version} %generate_buildrequires %pyproject_buildrequires %build Example build with changes: https://koji.fedoraproject.org/koji/taskinfo?taskID=141474762 Pull request: https://github.com/redhat-performance/badfish/pull/482 c) Why is zlib-devel required? It might be cleaner to use python bindings to zlib. d) Approved. Please fix (a) and (b) before import. Consider implementing (c). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2268405 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268405%23c33 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
