https://bugzilla.redhat.com/show_bug.cgi?id=2432587
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Benson Muite <[email protected]> --- Seems good. A couple suggestions: a) Please change %{_libdir}/lib%{name}.so.* to %{_libdir}/lib%{name}.so.1{,.*} sonames should not be globbed. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files b) Consider also packaging the GPL-2 license text: https://github.com/msteinert/bstring/pull/120 see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text c) Approved. Please fix (a) before import. Please fix (b), as a choice of licenses are allowed, will not block on GPL-2-only as the BSD-3-Clause could be the only one that is used in Fedora d) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2432752 would be appreciated if time allows. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2432587 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432587%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
