https://bugzilla.redhat.com/show_bug.cgi?id=2431607
--- Comment #7 from Zdenek Dohnal <[email protected]> --- (In reply to Maxwell G from comment #5) > Package approved, but I noticed two other minor things to change before you > import the package: > > > > %files > > %{_mandir}/man8/ipp-usb.8.* > > * Please change this > > to %{_mandir}/man8/ipp-usb.8* > > to match the format in > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. Np, I will change it. Just curious - do you know the reason behind the format? Man pages are automatically compressed during RPM build, so they will be in format 'name.N.<compression format>', where IMO compression format can change, thus the suffix wildcard. > > > > %{_sbindir}/ipp-usb > > * I would just reference %{_bindir} here and in %install now that /usr/sbin > -> /usr/bin (https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin) A fair point - I've checked the functionality 'ipp-usb check' worked fine, so LGTM atm. > > Vendored Go Package Review > ============== > > This package was generated using go2rpm and Go Vendor Tools, which > simplifies the review. > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > - [x] The specfile is legible. > - [x] The SRPM contains a valid `go-vendor-tools.toml`. > - The default `detector = "askalono"` is included unless there is > justification. > - Manual license overrides are correct. > - [x] The latest version is packaged or packaging an earlier version is > justified. > - [x] The License tag reflects the package contents and uses the correct > identifiers. > - [x] The package builds successfully in mock. > - [x] Package is installable (checked by fedora-review). > - [x] There are no relevant rpmlint errors. > - [x] The package runs tests in %check. > - [x] `%goipath` is set correctly. > - [x] The package's binaries don't conflict with binaries already in the > distribution. (Some Go projects include utility binaries with very generic > names) > - [x] There are no `%{_bindir}/*` wildcards in %files. > - [x] The package does not use `%gometa -f` if it has dependents that still > build for %ix86. > - [x] The package complies with the rest of the Golang and general Packaging > Guidelines. I use 'fedora-review' tool to check the package - how can I run this specific package review automatically? I see you have the checklist on your git, but I don't know how to run it - or you do it manually? (In reply to Maxwell G from comment #6) > Thanks! Thank you as well! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2431607 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431607%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
