https://bugzilla.redhat.com/show_bug.cgi?id=2418596

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED



--- Comment #2 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 

FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
FIX: Please specify all dependencies in BuildRequires
     perl(base) - Chemistry-File-XYZ-0.11/XYZ.pm:6
     perl(Carp) - Chemistry-File-XYZ-0.11/XYZ.pm:8
     perl(Chemistry::File) - Chemistry-File-XYZ-0.11/XYZ.pm:6
     perl(strict) - Chemistry-File-XYZ-0.11/XYZ.pm:9
     perl(warnings) - Chemistry-File-XYZ-0.11/XYZ.pm:10

$ rpm -qp --requires perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm | sort |
uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(Chemistry::File)
      1 perl(Chemistry::Mol)
      1 perl-libs
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm | sort |
uniq -c
      1 perl(Chemistry::File::XYZ) = 0.11
      1 perl-Chemistry-File-XYZ = 0.11-1.fc44
Binary provides are Ok.

$ rpmlint perl-Chemistry-File-XYZ-0.11-1.fc44.noarch.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

perl-Chemistry-File-XYZ.noarch: E: spelling-error ('Mol', '%description -l
en_US Mol -> Mo, Moll, Moe')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1
badness; has taken 0.1 s

Rpmlint is ok

NOTE: Is there any special reason why you use control via 'check' macro?

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new
spec file.

Resolution:
NOT Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2418596

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418596%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to