https://bugzilla.redhat.com/show_bug.cgi?id=2432682
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Ben Beasley <[email protected]> --- Looking over this quickly (not quite at the necessary level of detail for a full review just yet), this looks quite reasonable. However, I’m pretty sure you ought to build this with TLS/SSL support, which is as simple as: BuildRequires: pkgconfig(openssl) and with support for asynchronous DNS resolution, which is enabled by default in the upstream build system as long as the c-ares library is available: BuildRequires: cmake(c-ares) You might also choose to enable spdlog support: this appears to just add to the C++ API for those who want to integrate with spdlog (look for the TRANTOR_SPDLOG_SUPPORT conditional macro in trantor/utils/Logger.cc), with no consequences for those who don’t. This is as simple as BuildRequires: cmake(spdlog) plus passing -DUSE_SPDLOG=ON to %cmake. ---- Version 1.5.26 is available. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432682 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432682%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
