https://bugzilla.redhat.com/show_bug.cgi?id=2431593
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #27 from Fabio Valentini <[email protected]> --- Hello 👋 bit confused by some of the choices made in the spec file. 1. Why define "%global bundled_rust_deps 0"? This is not used anywhere. 2. Directly having "BuildRequires: openssl-devel" should not be necessary. This dependency is pulled in by the rust-openssl-sys crate package. 3. "BuildRequires: rust-tempfile+default-devel" is wrong. The package should pass `-t` to %cargo_generate_buildrequires instead. Refer to the "https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_non_crate_rust_project"; template. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2431593 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431593%23c27 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
