https://bugzilla.redhat.com/show_bug.cgi?id=2435617
Jonathan Lebon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |) | --- Comment #3 from Jonathan Lebon <[email protected]> --- Awesome, thank you for the review! Spec URL: https://download.copr.fedorainfracloud.org/results/jlebon/chunkah/srpm-builds/10092440/chunkah.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jlebon/chunkah/srpm-builds/10092440/chunkah-0.1.1-1.fc43.src.rpm (In reply to John Eckersberg from comment #2) > - (Blocker) Must provide `bundled(crate(xxx))` for each dependency. > Looks like this is handled by %cargo_vendor_manifest described here: > > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ > #_using_vendor_tarballs > > bootc currently does this and looks correct so should be easy to > just copy from there. Good catch. Fixed! > - (Non-blocker) We should probably have at least a basic manpage. For > reference bootc generates most of that from clap but it's somewhat > involved and I don't think it's worth holding the review up over it. Yes, I need to figure out the manpage strategy. And now I see bootc is using something similar to coreos-installer. I might do the same... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2435617 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435617%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
