https://bugzilla.redhat.com/show_bug.cgi?id=2435920
--- Comment #2 from Peter Lemenkov <[email protected]> --- Ok, looks good but I still have some proposals. * Remove pushd build..popd - out %cmake and %ctest macros already changing working directory to "redhat-linux-build" so it won;'t mess with source code. * Remove "ls && ls contrib" leftovers * Instead of creating user and group in old-fashioned way consider using systemd for that. See for example - https://src.fedoraproject.org/rpms/mpdscribble/blob/rawhide/f/mpdscribble.spec#_44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2435920 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435920%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
