https://bugzilla.redhat.com/show_bug.cgi?id=2435517
Tomi Lähteenmäki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Tomi Lähteenmäki <[email protected]> --- Marking this approved but before you import the package: - Number the sources, i.e. change `Source:` to `Source0:`. - If you don't plan to build this for EPEL 9 or older, then consider moving `%cmake` to `%conf` section; the Packaging Guidelines example for CMake [1] will be soon updated [2] to account that. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_example_usage [2] https://pagure.io/packaging-committee/pull-request/1524 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2435517 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202435517%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
