https://bugzilla.redhat.com/show_bug.cgi?id=2333620
--- Comment #6 from Ruslan Bekenev <[email protected]> --- Thank you, Benson! I looked at the guidelines and manually checked what I could and only after that I discovered fedora-review package. Here is my note and the review report ------------- Looks good! The only difficulty I have here is to understand why /usr/lib/node_modules is marked as a directory without owner. The directory is %{nodejs_sitelib} macro, I would assume it is owned by node isn't it? I ran "dnf provides /usr/lib/node_modules" and got two nodejs related packages: nodejs-cjs-module-lexer and nodejs-undici. Non of them is nodejs itself. I'm not sure how to interpret this. Also rpmlint has 5 errors that say "incorrect-fsf-address" but I can't find any emails in the files mentioned. Sounds like false-positive. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "*No copyright* ISC License and/or MIT License", "GNU General Public License v3.0 or later", "*No copyright* Academic Free License v3.0 and/or Apache License 2.0", "MIT License", "*No copyright* MIT License", "ISC License", "*No copyright* ISC License". 307 files have unknown license. Detailed output of licensecheck in /var/home/krydos/Projects/fedora- review/eask/2333620-eask/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/node_modules [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11029 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: eask-0.12.4-1.fc45.noarch.rpm eask-0.12.4-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqnaukf0q')] checks: 32, packages: 2 eask.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/eask/README.md eask.noarch: W: only-non-binary-in-usr-lib eask.noarch: W: no-manual-page-for-binary eask eask.spec: W: no-%build-section eask.spec: W: invalid-url Source1: @emacs-eask-cli-0.12.4-nm-prod.tgz eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/ansi.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-build-badges.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-build.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-recipe-mode.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-recipe.el eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.package-lock.json eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.jshintrc eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.npmignore eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.travis.yml 2 packages and 0 specfiles checked; 5 errors, 12 warnings, 27 filtered, 5 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 eask.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/eask/README.md eask.noarch: W: only-non-binary-in-usr-lib eask.noarch: W: no-manual-page-for-binary eask eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/ansi.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-build-badges.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-build.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-recipe-mode.el eask.noarch: E: incorrect-fsf-address /usr/lib/node_modules/eask/lisp/extern/package-build/24/package-recipe.el eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.bin eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.package-lock.json eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.jshintrc eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.npmignore eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.travis.yml 1 packages and 0 specfiles checked; 5 errors, 10 warnings, 23 filtered, 5 badness; has taken 0.1 s Source checksums ---------------- https://registry.npmjs.org/@emacs-eask/cli/-/cli-0.12.4.tgz : CHECKSUM(SHA256) this package : 80910c2cec6af14e102ff19ee0d05991d11cf8ad4394de5ad8444f2f201e048b CHECKSUM(SHA256) upstream package : 80910c2cec6af14e102ff19ee0d05991d11cf8ad4394de5ad8444f2f201e048b Using local file /var/home/krydos/Projects/fedora-review/eask/@emacs-eask-cli-0.12.4-nm-prod.tgz as upstream file:///var/home/krydos/Projects/fedora-review/eask/@emacs-eask-cli-0.12.4-nm-prod.tgz : CHECKSUM(SHA256) this package : 80d13ddd0ee8df8bb317bddf7058b3861531a9969b0bbb085eaa8490f296962e CHECKSUM(SHA256) upstream package : 80d13ddd0ee8df8bb317bddf7058b3861531a9969b0bbb085eaa8490f296962e Using local file /var/home/krydos/Projects/fedora-review/eask/@emacs-eask-cli-0.12.4-bundled-licenses.txt as upstream file:///var/home/krydos/Projects/fedora-review/eask/@emacs-eask-cli-0.12.4-bundled-licenses.txt : CHECKSUM(SHA256) this package : d432bd46910594facf19d6765da133dd4762a92b349a00e04d078f298e1adfea CHECKSUM(SHA256) upstream package : d432bd46910594facf19d6765da133dd4762a92b349a00e04d078f298e1adfea Requires -------- eask (rpmlib, GLIBC filtered): /usr/bin/node nodejs nodejs(engine) Provides -------- eask: bundled(nodejs-ansi-regex) bundled(nodejs-ansi-styles) bundled(nodejs-cliui) bundled(nodejs-color-convert) bundled(nodejs-color-name) bundled(nodejs-emoji-regex) bundled(nodejs-escalade) bundled(nodejs-get-caller-file) bundled(nodejs-is-fullwidth-code-point) bundled(nodejs-isexe) bundled(nodejs-require-directory) bundled(nodejs-string-width) bundled(nodejs-strip-ansi) bundled(nodejs-which) bundled(nodejs-wrap-ansi) bundled(nodejs-y18n) bundled(nodejs-yargs) bundled(nodejs-yargs-parser) eask npm(@emacs-eask/cli) Diff spec file in url and in SRPM --------------------------------- --- /var/home/krydos/Projects/fedora-review/eask/2333620-eask/srpm/eask.spec 2026-02-08 15:42:20.420342274 +1100 +++ /var/home/krydos/Projects/fedora-review/eask/2333620-eask/srpm-unpacked/eask.spec 2026-02-06 11:00:00.000000000 +1100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global npm_scope emacs-eask %global npm_name cli @@ -66,3 +76,15 @@ %changelog -%{autochangelog} +## START: Generated by rpmautospec +* Fri Feb 06 2026 Peter Oliver <[email protected]> - 0.12.4-1 +- Update to version 0.12.4. + +* Fri Feb 06 2026 Peter Oliver <[email protected]> - 0.12.0-2 +- BuildRequires: /usr/bin/node + +* Sun Dec 21 2025 Peter Oliver <[email protected]> - 0.12.0-1 +- Update to version 0.12.0. + +* Fri Dec 20 2024 Peter Oliver <[email protected]> - 0.10.2-1 +- Initial package. +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/sbin/fedora-review -b 2333620 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, R, SugarActivity, Haskell, Java, fonts, C/C++, Perl, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2333620 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333620%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
