https://bugzilla.redhat.com/show_bug.cgi?id=2388154
--- Comment #15 from Miroslav Suchý <[email protected]> --- > # License expression simplified by eliminatation, as permitted License tag is missing: (BSD-2-Clause OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0) AND (Apache-2.0 OR MIT) You should not evaluate and simplify the boolean formula. See https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis > # A patch I wrote, updating the sources for PyO3 0.27 support > Patch: https://github.com/huggingface/tokenizers/pull/1941.patch This is better written as: # A patch I wrote, updating the sources for PyO3 0.27 support # https://github.com/huggingface/tokenizers/pull/1941 Patch: 1941.patch This way you can easily check the status of the PR. If it was already merged or not. But I will treat it as style preference and will not block on this. > # Fill in the actual package description to submit package to Fedora This is from the template and can be removed. > # Update some deps to the latest version Personally, I would change it to >= of these versions instead of one specific version, otherwise the maintenance will be painful for you. I will not block on this. > %files -n python3-tokenizers -f %{pyproject_files} You have to add here: %license LICENSE %license LICENSE.dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388154 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388154%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
