https://bugzilla.redhat.com/show_bug.cgi?id=2437502



--- Comment #3 from Miroslav Suchý <[email protected]> ---
> rm -rf %{buildroot}

This is not needed.

> License:        GPLv3
This is not SPDX ID. See
https://docs.fedoraproject.org/en-US/legal/license-field/

> install -p -m 0644 LICENSE.txt %{buildroot}%{_datadir}/%{name}/

This is not needed. %license macro in %files section does that for you.

> # Disable debuginfo to keep the package simple for this project
> %define debug_package %{nil}

This has to be removed.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2437502

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to