https://bugzilla.redhat.com/show_bug.cgi?id=2439345
Mikel Olasagasti Uranga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Status|NEW |ASSIGNED --- Comment #1 from Mikel Olasagasti Uranga <[email protected]> --- - You're missing correct LDFLAGS: https://github.com/AvengeMedia/dgop/blob/master/Makefile#L19C1-L19C14 Add this after GO111MODULE line: export GO_LDFLAGS="-X main.commit=fedora \ -X main.Version=%{version} \ -X main.buildTime=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d_%H:%M:%S)" You should replace commit=Fedora with a proper hash as desribed in the Makefile, but as that makes automating updates with Packit more complex having a static string is not the worst idea. - go-vendor-tools > Source2: %{name}-go-vendor-tools.toml I would suggest to drop the %{name} prefix before importing to follow the standard in the rest of the packages until prefixing is included as an option for the tooling. Not required as part of the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2439345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202439345%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
